Widget Importer: Fix Widget Group block imports #48669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +107 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 996af3a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4312114997
|
|
The PR is ready for review, but it looks like the Widget editor is broken on Gutenberg trunk and WP 6.2 beta4. I'm seeing the following errors when trying to insert block widgets. Screeenshot
|
Mamaduka
added
[Type] Bug
ntsekouras
approved these changes
Mar 2, 2023
Mamaduka
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Mar 7, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 97fdf1f |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #47081.
PR updates the Template Parts widget importer to convert Widget Group blocks into the Group block and adds logic to transform legacy widgets inside inner blocks.
Why?
See #47081.
How?
transformWidgetToBlockto return already converted blocks to be used in the template.switchLegacyWidgetTypehelper.Testing Instructions
Note: Only legacy widgets with available transformations will be added to the template part. Use the Classic Widgets plugin to test the core legacy widgets.
Screenshots or screencast