ConfirmDialog: Replace 'OK' with more descriptive label

[afercia]

Description

See also #60027

The ConfirmDialog component was introduced in #34153 because of two main purposes:

Quoting from the related issues, see #16583 and #33937

• The native window.confirm() isn't an ideal experience as we're unable to customise the OK button to have a more descriptive label.
• Major browsers - starting with Chrome - will soon restrict the alert/confirm/prompt functions from being used from within cross-origin iframes.

Regarding the first point, it appears some instances of the ConfirmDialog just use the default OK button text, thus defeating one of the purposes it was introduced for.

I'd tend to think re-enforcing the in-progress action by using a more meaningul button text would make the user experience better. Also, there's some inconsistency throughout the UI. I'd tend to think all ConfirmDialog should either use 'OK' oar a more specific text.

Some exampke screenshots:

Step-by-step reproduction instructions

• Go through all ConfirmDialogs
• Observe the inconsistent pattern for the confirm button text.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[afercia]

Worth also noting that the 'Best practices` section added to the component readme in #59825 now recommends to:

Use a descriptive text for the confirm button.

[afercia]

The ConfirmDialog used for switching to template editing is a special case. To me, its usage isn't ideal in the first place.

A ConfirmDialog should be used 'only for short confirmation messages where a cancel and confirm actions are provided.'.
The copy of this instance doesn't make very clear what the action to confirm is. It onlyy tells used they just did something.

You’ve tried to select a block that is part of a template, which may be used on other posts and pages.

Instead, ideally the copy should ask a question or, at least, the action to confirm should me more clear.

Screenshot:

Update:
I struggled a bit understanding how to make this ConfirmDialog appear. Steps:

• Go to the Site editor > Pages > edit a page.
• Double click on an empty area at the side of a block provided by the page template, e.g. the page title.

Originally, the copy of this dialog in #51366 was Edit your template to edit this block..

In #60016 it was changed to You’ve tried to select a block that is part of a template, which may be used on other posts and pages. I do understand why it was changed, as the underlying functionality changed. However, a confirm dialog copy should always ask a question, whether it's an explicit or implicit question. I would like to change this copy, I'll try to think at something meaningful anc concise. Any suggestion would be appreciated Cc @noisysocks

[afercia]

What about Would you like to edit the template this block is part of?

[afercia]

The copy Any unsaved changes will be lost when you apply this revision. should be changed as well, to ask a question. I'd like to propose:

Are you sure you want to apply this revision? Any unsaved changes will be lost.

[noisysocks]

What about Would you like to edit the template this block is part of?

Thanks for flagging. Works for me. I think we could drop the last part so that it is:

You've tried to select a block that is part of a template, which may be used on other posts and pages. Would you like to edit the template?

[Cancel] [Edit template]

[afercia]

Thanks for the feedback, A little verbose but it works for me.