Make the delete navigation menu confirm dialogs consistent #59825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Block] Navigation
|
Size Change: +2.73 kB (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
afercia
force-pushed
the
fix/delete-navigation-menu-confirm-dialog
branch
from
142209a to
7cf8103
Compare
afercia
force-pushed
the
fix/delete-navigation-menu-confirm-dialog
branch
from
7cf8103 to
70cc05d
Compare
jasmussen
approved these changes
Mar 19, 2024
Good point, thqqnks. Also, the |
|
Probably worth a follow-up to stabilize it. |
Will create a new issue, thanks. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…#59825) * Make the delete navigation menu confirm dialogs consistent. * Simplify and make consistent the deleted menu snackbar notices. * Add Best practices section to readme. Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59788
What?
Navigation menus can be deleted from the editor navigation panel and from the navigation block inspector. For consistency, the user flow should be as similar as possible however the confirmation dialogs are different.
The Snackboar notices after successful deletion should look similar as well.
Why?
Consistency is key. Making the two confirmation dialogs look the same and work the same helps usability and reduces cognitive load. Also, reduces code.
How?
Use a
ConfirmDialogcomponent instead of a custom Modal.Simplifies and makes consistent the Snackbar notices text.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before:
After: