-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm dialog: use more descriptive text for the confirm button #60364
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +63 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
912357a
to
43e8471
Compare
879d64c
to
f4e8e3b
Compare
I updated the text for the 'edit template' confirm dialog as suggested in #60360 (comment) Cc @noisysocks |
f4e8e3b
to
7a284fc
Compare
Fixes #60360
What?
Some of the
ConfirmDialg
instances use the generic, default 'OK' text for the confirm button. They should use a more descriptive text.Also, ideally the confirm dialog copy should always ask a question.
Why?
A more descriptive text helps users better understand what the 'confirm' action does. Also, the
ConfirmDialg
was implemented with the purpose of providing a more descriptive text than the generic 'OK'.How?
Provides a more descriptive text for the copy and the confirm button.
Testing Instructions
Would you like to edit the template this block is part of?
.Are you sure you want to apply this revision? Any unsaved changes will be lost.
.Testing Instructions for Keyboard
Screenshots or screencast