Fix faulty Jed state after setLocaleData #10233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `setLocaleData` with a custom textdomain in a non-Gutenberg environment the default textdomain ends up in a state that is not ok with Jed resulting in the error: "Error: No locale meta information provided." In Gutenberg this is not a problem because `setLocaleData` is always called first with the default textdomain.
|
Note: I can add a changelog entry, but I have no idea how to describe this concisely. |
gziolo
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calling
setLocaleDatawith a custom textdomain in a non-Gutenberg environment the default textdomain ends up in a state that is not ok with Jed resulting in the error: "Error: No locale meta information provided." In Gutenberg this is not a problem becausesetLocaleDatais always called first with the default textdomain.How has this been tested?
Using
hotfix/8.3.1of Yoast SEO we found this bug. After the removal ofgetI18nfrom our code we uncovered this.Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: