Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jed localization error in classic editor #11113

Closed
IreneStr opened this issue Sep 28, 2018 · 1 comment
Closed

Jed localization error in classic editor #11113

IreneStr opened this issue Sep 28, 2018 · 1 comment
Milestone
8.4

Comments

@IreneStr
Copy link
Contributor

IreneStr commented Sep 28, 2018 •
edited
Loading

Since #10945 has been merged, there is a Jed localization error in the classic editor and the classic editor plugin when you open/create a post:
schermafbeelding 2018-09-28 om 09 22 31

Use the hotfix/8.3.1 branch to reproduce.

Fix this on the hotfix/8.3.1 branch
@IreneStr IreneStr added this to the 8.3.1 milestone Sep 28, 2018
@IreneStr
Copy link
Contributor Author

This turned out to be a combination of a missing text-domain (see PR) and a @WordPress/i18n bug: WordPress/gutenberg#10233. Only the PR on this repo is sufficient to fix the error.

@IreneStr IreneStr mentioned this issue Sep 28, 2018
Merged
2 tasks
@IreneStr IreneStr self-assigned this Sep 28, 2018
@afercia afercia assigned afercia and unassigned IreneStr Sep 28, 2018
@afercia afercia assigned IreneStr and unassigned afercia Sep 28, 2018
@afercia afercia assigned afercia and unassigned IreneStr Sep 28, 2018
@afercia afercia closed this as completed Sep 28, 2018
@afercia afercia removed their assignment Sep 28, 2018
@IreneStr IreneStr added the bug label Sep 28, 2018
@IreneStr IreneStr modified the milestones: 8.3.1, 8.4 Oct 1, 2018
@abotteram abotteram mentioned this issue Oct 10, 2018
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4
Development

No branches or pull requests
2 participants
@afercia @IreneStr