Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText: mark onSplit as unstable #11926

Merged
merged 2 commits into from
Nov 15, 2018
Merged

Conversation

ellatrix
Copy link
Member

Description

onSplit is an being revised in #11005, but it's not sure when we can land this change. In the meantime it would be good to mark onSplit as unstable. It's a relatively small deprecation. I don't expect many non core blocks to use this prop. Even in core we only use it for 3 blocks.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@ellatrix ellatrix added the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label Nov 15, 2018
@ellatrix ellatrix added this to the 4.4 milestone Nov 15, 2018
@ellatrix ellatrix requested a review from a team November 15, 2018 16:22
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see it in the native versions of heading and paragraph, not sure how to go about that. cc @gziolo @hypest

@ellatrix
Copy link
Member Author

@youknowriad That's probably fine, RichText is entirely different there as well, handling the onSplit prop.

@youknowriad
Copy link
Contributor

Ideally they should align because the goal is that plugin author using RichText will have a block working in both editors without code changes. It's probably not as urgent as 4.4 but something we should follow-up on.

@youknowriad
Copy link
Contributor

I'm merging this, let's make sure we follow-up with what's needed for mobile.

@youknowriad youknowriad merged commit 55d7d33 into master Nov 15, 2018
@youknowriad youknowriad deleted the try/mark-on-split-unstable branch November 15, 2018 18:15
@hypest
Copy link
Contributor

hypest commented Dec 13, 2018

Late to the party but, @daniloercoli , @diegoreymendez can you check if there are things we need to do or update for the gutenberg-mobile side? Thanks!

@daniloercoli
Copy link
Contributor

I've created a new issue for this gutenberg-mobile side, since we want to port the changes above to mobile. Probably in the beta Milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants