Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichText: mark onSplit prop as unstable #394

Closed
daniloercoli opened this issue Dec 18, 2018 · 3 comments
Closed

RichText: mark onSplit prop as unstable #394

daniloercoli opened this issue Dec 18, 2018 · 3 comments
Milestone
Beta

Comments

@daniloercoli
Copy link
Contributor

onSplit prop is an being revised in #gb-11005, and in the meantime it was marked as unstable here: WordPress/gutenberg#11926

We should mark it as unstable on mobile too.
@daniloercoli daniloercoli added this to the Beta milestone Dec 18, 2018
@mkevins mkevins mentioned this issue Feb 20, 2019
Open
20 tasks
@koke
Copy link
Member

koke commented Apr 4, 2019

@daniloercoli I'm moving this to the Future column, since it doesn't seem like a bug that would affect users, and the discussion seems to be still going in WordPress/gutenberg#14765

I don't understand the implications of this (I'd appreciate a quick explanation), so we might still want to tackle it soon, but I'd keep it out of the bug fixes column until then, and leave that for things that affect the UX.

@mkevins
Copy link
Contributor

mkevins commented May 22, 2019

@daniloercoli WordPress/gutenberg#14765 has been merged. I think this PR can resolve this issue: #1013.

@daniloercoli
Copy link
Contributor Author

Right @mkevins. #1013 updated the mobile side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Beta
Development

No branches or pull requests
3 participants
@koke @daniloercoli @mkevins