[RN mobile] Accessibility: Handle the iOS z-gesture to exit modals and block selection #15153
Conversation
gziolo
added
the
Mobile App - i.e. Android or iOS
There was a problem hiding this comment.
"Hey Siri, activate VoiceOver"
Nice tip!
The Z gestures work beautifully to deselect the selected block and to dismiss modals 🎉
I left a small comment for the long press gesture hint. Otherwise it works great on iOS.
As mentioned, Android doesn't perform as well, but there are known issues that are preventing us to have a great TalkBack experience. Let's continue as it is and solve those Android issues later on.
| accessible={ true } | ||
| disabled={ ! isSelected } | ||
| accessibilityLabel={ alt } | ||
| accessibilityHint={ __( 'Long press to edit the image' ) } |
There was a problem hiding this comment.
you may have to tap once first, it's like a double tap but on the second tap your finger stays on the screen
As you mentioned, with VoiceOver, this is not really a Long Press gesture, but a Double tap and hold gesture.
I found in the Mail app an example with the "Compose new e-mail" button (bottom right corner).
The normal tap opens the e-mail composer and a long press opens the Drafts screen.
VoiceOver says: "Compose. Button. (hint) Double tap and hold to bring up Drafts".
Let's use this same way of communicating the gesture with VoiceOver. :)
…t reachable anymore
There was a problem hiding this comment.
Tested on WPiOS and working pretty good. I think z-gesture will help users a lot. 🎉
I just realized that talkback can say image block. undefined. but it is not directly related with this PR, maybe we could fix that in wordpress-mobile/gutenberg-mobile#937 and secure the undefined variables as alt || '' or caption || ''
…ity-ios-z-gesture
Description
This PR adds support for the z-gesture (see https://facebook.github.io/react-native/docs/accessibility.html#onaccessibilityescape-ios).
It also adds support for long press edit of the image inside the image block.
How has this been tested?
Tested with wordpress-mobile/gutenberg-mobile#926