-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RN mobile] Accessibility: Handle the iOS z-gesture to exit modals and block selection #15153
Merged
Merged
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3312736
Close the modal on z-gesture on iOS
Tug 36b42da
Disable cancel and retry dialog if image is already uploaded
Tug cc2cae5
Fix long press disabled by TouchableWithoutFeedback wrapper
Tug 38137b3
Merge remote-tracking branch 'origin/master' into rnmobile/accessibil…
Tug 389c52a
Merge branch 'master' into rnmobile/accessibility-ios-z-gesture
etoledom 8d6cd64
Updated image label for double tap and hold gesture
etoledom 0c4762b
Merge branch 'master' into rnmobile/accessibility-ios-z-gesture
etoledom 968909d
Remove long press gesture from image, since edit image function is no…
etoledom 7b31b11
Merge branch 'master' into rnmobile/accessibility-ios-z-gesture
etoledom a65abfa
Merge branch 'master' into rnmobile/accessibility-ios-z-gesture
etoledom 03c6df3
Solve merge conflict
etoledom b92367c
Adding long press gesture to image block on selected state
etoledom cf5c0d7
Merge branch 'master' into rnmobile/accessibility-ios-z-gesture
etoledom 12ff491
Fix lint issues
etoledom 93c7067
Merge remote-tracking branch 'origin/master' into rnmobile/accessibil…
Tug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you mentioned, with VoiceOver, this is not really a
Long Press
gesture, but aDouble tap and hold
gesture.I found in the Mail app an example with the "Compose new e-mail" button (bottom right corner).
The normal tap opens the e-mail composer and a long press opens the Drafts screen.
VoiceOver says: "Compose. Button. (hint) Double tap and hold to bring up Drafts".
Let's use this same way of communicating the gesture with VoiceOver. :)