Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder instructions: Make texts more consistent #16339

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Placeholder instructions: Make texts more consistent #16339

merged 1 commit into from
Jun 28, 2019

Conversation

Soean
Copy link
Member

@Soean Soean commented Jun 27, 2019

Description

The placeholder text for media should be in this structure

For when there's a URL option:
Upload a [type] file, pick one from your media library, or add one with a URL.

See #16135

This PR adds the word 'file' to the string, so that this string is consistent with the media-placeholder component.

@Soean Soean added the [Type] Copy Issues or PRs that need copy editing assistance label Jun 27, 2019
@Soean Soean requested a review from kjellr June 27, 2019 21:11
@Soean Soean self-assigned this Jun 27, 2019
@Soean Soean added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Jun 28, 2019
kjellr
kjellr approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Soean! 🚢

@Soean Soean merged commit 95c515a into master Jun 28, 2019
@Soean Soean deleted the fix/upload-image-text-translation-consistency branch June 28, 2019 16:04
@youknowriad youknowriad added this to the Gutenberg 6.1 milestone Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjellr kjellr kjellr approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@notnownikki notnownikki Awaiting requested review from notnownikki

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@Soean Soean

Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Milestone
Gutenberg 6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Soean @kjellr @youknowriad