[wip] Update/image block alignment #16711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrofox
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
Soean,
talldan and
youknowriad
as code owners
retrofox
force-pushed
the
update/image-block-alignment
branch
from
f5e7c78
to
0e780e1
Compare
mtias
reviewed
Jul 24, 2019
| @@ -62,6 +62,9 @@ | |||
| "source": "attribute", | |||
| "selector": "figure > a", | |||
| "attribute": "target" | |||
| }, | |||
| "fullScreen": { | |||
There was a problem hiding this comment.
Let's try adding this to the block-alignment component itself so that it's available to all blocks that use wide alignments.
There was a problem hiding this comment.
Let's try adding this to the block-alignment component itself so that it's available to all blocks that use wide alignments.
When read it I'd already done a different approach which is not aligned what your note above Sorry about this :-/. I've added a Why adding a new <Toolbar />? section in the PR description.
|
Closing this one in favor of #16738 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new button to the toolbar for the
core/imageblockIt tries to tackle #16385
https://cloudup.com/corIGmn7AsB