-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore using a modal to replace the publish panel #16715
Conversation
ccab890
to
d6abe21
Compare
I have made some updates to bring this into line with an updated prototype in #7602 (comment). I also made a few intentional changes:
Leaving this as a Draft PR as there is quite a bit of back and forth in #7602 about whether a modal is a step forward or not. Hoping that this work will move the conversation forward by being able to experience it, but understand this is far from a settled direction for the publishing flow. (I will also work on getting a version up with this prototype in a full screen modal early next week @karmatosed) |
Thanks for working on this @brentswisher. I have a few pieces of feedback but feel I need to see this in full screen modal first. For me right now the experience is really distracting hopping from one size to other. I also feel the layout is a little confusing. Let's get this into the modal though first and then iterate. It's helpful to see as a prototype and really focuses on evaluating the experience. |
…d post-publish information, replaces the current postPublishPanel
…h panel but not needed in the modal
…lization in english, it would be incorrect in other languages. Will have to explore if this exists somewhere already that would work for all languages.
03b2bfb
to
ed3adb5
Compare
@karmatosed - I wasn't sure the easiest way to combine this with another work in progress branch to demo a full screen modal for publishing, so I created a new branch that has both here: #17225 Hopefully, that isn't too confusing? Let me know if I can help with anything else to make it easier to see. |
It seems like this isn't a direction that is moving forward, working on cleaning up old PR's so I plan on closing this out next week unless there is some objection that it might still be useful. (Thoughts @karmatosed?) |
@brentswisher I think closing this is fine. I'll do that now. Thanks. |
This is a rough attempt at adding a modal as described in #15847. This is a first step toward enhancing the publishing flow, based off of the designs by @sarahmonster and others tracked in #7602. It will need some additional work, but I thought it would be useful to get some feedback on it at this stage before continuing. The conversation about these changes is a bit fragmented so I am hoping that having some code to look at will help prioritize next steps.
@sarahmonster - Thank you for the great design work, you will notice some of the wording different from the mockups. In working through the code there were some variations between the existing panel and the mockups, usually around wording for scheduled posts. Where it made sense to me I kept the same messages if they were similar enough, but I'm happy to change as needed.
Open to any and all criticisms and suggestions. I used the existing postPublishPanel as a rough framework, and I need to review if some of the logic makes sense as a modal. I'll continue to update this as I have availability and depending on if it's looking like a direction worth exploring.
Additional plans for now: