Fix full-wide on mobile regression. #18469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
jasmussen
requested review from
ellatrix,
talldan and
youknowriad
as code owners
5 tasks
|
Tests don't seem to be completing. |
|
Weird, can you try to rebase and push again? |
jasmussen
force-pushed
the
fix/full-wide-regression
branch
from
3f862f6
to
3606f0a
Compare
|
Done, thank you. |
This is a followup to a regression found in #17875, specifically #17877 (comment). The PR refactored horizontal margins, including for full-wide blocks. As a result, full-wide blocks would, on the mboile breakpoint, receive too much negative margin. This PR addresses that.
jasmussen
force-pushed
the
fix/full-wide-regression
branch
from
3606f0a
to
597c129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to a regression found in #17875, specifically #17877 (comment).
The PR refactored horizontal margins, including for full-wide blocks. As a result, full-wide blocks would, on the mboile breakpoint, receive too much negative margin.
This PR addresses that.
To test, insert any full wide block, though it's easier to see with the table block as it gets more visibly cropped. Test in TwentyTwenty and with vanilla styles. Test both on mobile (<600px) breaktpoint, and above. There should be no cropping, and no horizontal scrollbars.
However please note that there is an issue with TwentyNineteen editor styles as a result of the PR, and those need to be fixed separately as they need new styles. That is trac'ed here: https://core.trac.wordpress.org/ticket/48526
Screenshots: