Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] - Activate preformat on android #18720

Closed
wants to merge 14 commits into from
Closed

[RNMobile] - Activate preformat on android #18720

wants to merge 14 commits into from

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Nov 25, 2019 •
edited
Loading

Description

Activate pre format block on Android platform: wordpress-mobile/gutenberg-mobile#1264

GB mobile PR: wordpress-mobile/gutenberg-mobile#1615

How has this been tested?

Follow test instructions on gb-mobile PR: wordpress-mobile/gutenberg-mobile#1615

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@marecar3 marecar3 added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 25, 2019
@marecar3 marecar3 changed the title Rnmobile/activate pre format android [RN MOBILE] - Activate pre format on android Nov 25, 2019
@marecar3 marecar3 changed the title [RN MOBILE] - Activate pre format on android [RNMobile] - Activate pre format on android Nov 25, 2019
@marecar3 marecar3 changed the title [RNMobile] - Activate pre format on android [RNMobile] - Activate preformat on android Nov 25, 2019
@marecar3 marecar3 mentioned this pull request Nov 25, 2019
Merged
1 task
@marecar3 marecar3 marked this pull request as ready for review November 25, 2019 15:44
SergioEstevao
SergioEstevao approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Gerardo Pacheco and others added 11 commits November 26, 2019 17:40
@maxme
[RNMobile] Enable Spacer block (#18605)
2a6bf6c
@marecar3
Merge branch 'rnmobile/activate_pre_format_android' of https://github…
405d959 
….com/WordPress/gutenberg into rnmobile/activate_pre_format_android
@marecar3
enable preformatted block for production and android
4a2d212
@marecar3
Fix lint errors
371ee90
@marecar3
Merge branch 'rnmobile/activate_pre_format_android' of https://github…
412c0d1 
….com/WordPress/gutenberg into rnmobile/activate_pre_format_android
@marecar3
enable preformatted block for production and android
40b9cba
@marecar3
Fix lint errors
9ad3068
@marecar3
Merge branch 'rnmobile/activate_pre_format_android' of https://github…
e3472a7 
….com/WordPress/gutenberg into rnmobile/activate_pre_format_android
@marecar3
enable preformatted block for production and android
8eb443b
@marecar3
Fix lint errors
909a499
@marecar3
Merge branch 'rnmobile/activate_pre_format_android' of https://github…
f07a14a 
….com/WordPress/gutenberg into rnmobile/activate_pre_format_android
@marecar3
Copy link
Contributor Author

Closing in favor #18777

@marecar3 marecar3 closed this Nov 27, 2019
@marecar3 marecar3 deleted the rnmobile/activate_pre_format_android branch November 27, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@mchowning mchowning Awaiting requested review from mchowning

@etoledom etoledom Awaiting requested review from etoledom

@hypest hypest Awaiting requested review from hypest

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marecar3 @SergioEstevao