Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preformatted block #1264

Closed
hypest opened this issue Aug 6, 2019 · 5 comments · Fixed by wordpress-mobile/WordPress-Android#10868 or #1615
Closed

Preformatted block #1264

hypest opened this issue Aug 6, 2019 · 5 comments · Fixed by wordpress-mobile/WordPress-Android#10868 or #1615
Assignees
Labels
Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile

Comments

@hypest
Copy link
Contributor

hypest commented Aug 6, 2019

Support the Gutenberg "Preformatted" block.

@hypest hypest added the Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile label Sep 14, 2019
@SergioEstevao SergioEstevao self-assigned this Sep 19, 2019
@SergioEstevao
Copy link
Contributor

@iamthomasbishop what font do you want to use for preformatted blocks/html?

Normally we use a monospace font, and in iOS the one available is Courier

@hypest is this font available on Android too?

@iamthomasbishop
Copy link
Contributor

@SergioEstevao What are we using on Aztec/HTML mode? We can use the same font we're using there for consistency. Another option (which I think is available, per this list) could be Menlo.

@iamthomasbishop
Copy link
Contributor

It's hard to tell what the default is on Android, so that could change my answer above 😄 I think Droid Sans Mono was the default at some point but not sure if that's still the case. Roboto Mono is also nice.

@SergioEstevao
Copy link
Contributor

@iamthomasbishop we were using Courier in Aztec, but Menlo looks so much better that I'm going to change in both. What size do you think we should use?

Do you mind to post here a little mockup? and also tell me what colour you want to use for the background of the Pre block.

@iamthomasbishop
Copy link
Contributor

we were using Courier in Aztec, but Menlo looks so much better that I'm going to change in both.

👍 Awesome.

As I understand it, pre should use the same font styling as code block, minus syntax highlighting and additional block settings (code language, show line numbers, etc). So let's match the code block styling that we documented here: #368

Our font-size can match what I mentioned in the issue mentioned above, 14px. If that's a bit too small, we can bump up to our base paragraph sizing of 16px.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment