Travis: Skip the deploy stage on PRs. #18788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiqueras
added
[Type] Build Tooling
aduth
approved these changes
Nov 27, 2019
| @@ -197,7 +197,7 @@ jobs: | |||
| - $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --cacheDirectory="$HOME/.jest-cache" --runTestsByPath $( awk 'NR % 4 == 3' < ~/.jest-e2e-tests ) | |||
|
|
|||
| - stage: deploy | |||
| if: branch = master | |||
| if: (NOT type IN (pull_request)) AND (branch = master) | |||
There was a problem hiding this comment.
Could be simpler as...
Suggested change
| if: (NOT type IN (pull_request)) AND (branch = master) | |
| if: type IN (push) AND branch = master |
Reference: https://docs.travis-ci.com/user/conditions-v1#integration
I don't really know what api and cron are used for, but I doubt we want this stage to run for anything other than push.
There was a problem hiding this comment.
api is for when you trigger a build through the API.
cron is for when a scheduled build runs.
We might have tools that trigger or schedule builds from master in the future and this would support that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #15159
Avoid dry-running the deploy stage in PRs to get the build time down.
See #17823 (comment).