Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Skip the deploy stage on PRs. #18788

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Travis: Skip the deploy stage on PRs. #18788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ jobs:
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --cacheDirectory="$HOME/.jest-cache" --runTestsByPath $( awk 'NR % 4 == 3' < ~/.jest-e2e-tests )

- stage: deploy
if: branch = master
if: (NOT type IN (pull_request)) AND (branch = master)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be simpler as...

Suggested change
if: (NOT type IN (pull_request)) AND (branch = master)
if: type IN (push) AND branch = master

Reference: https://docs.travis-ci.com/user/conditions-v1#integration

I don't really know what api and cron are used for, but I doubt we want this stage to run for anything other than push.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api is for when you trigger a build through the API.

cron is for when a scheduled build runs.

We might have tools that trigger or schedule builds from master in the future and this would support that.

name: Deploy Playground
env: INSTALL_WORDPRESS=false
install:
Expand Down