Convert BlockHTML component from class component to React hooks #18968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
ellatrix
reviewed
Dec 6, 2019
| }; | ||
|
|
||
| useEffect( () => { | ||
| setHtml( getBlockContent( block ) ); |
There was a problem hiding this comment.
I notice before that there was an isEqual check. Do you remember why? Does it make sense here?
There was a problem hiding this comment.
I think it's not necessary because the useState hook won't rerender if we end up with the same html content.
There was a problem hiding this comment.
But the useEffect hook will still be called? I guess it's ok to re-set the HTML?
ellatrix
approved these changes
Dec 6, 2019
|
I removed the previous test because it was testing the implementation details and not really the behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small refactoring PR that shouldn't have any impact aside improving our code quality and following the last guidelines (prefer react hooks)
Testing instructions
Ensure that "Edit HTML" works as before.