-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlockHTML: Use correct type when setting 'html' state onBlur #49191
Conversation
Size Change: -4 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for fixing this!
Flaky tests detected in b466de9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4465753087
|
What?
PR fixes the
html
state type when setting it on theonBlur
event. It was causing[Object object]
to flash briefly in the input field.Props to @talldan for noticing the issue #49097 (comment).
Why?
This was leftover from previous refactoring #18968.
Testing Instructions
Confirm "Edit as HTML" works as before.
Screenshots or screencast
CleanShot.2023-03-20.at.11.25.55.mp4