Prevent select all behavior when shift key is pressed #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
reviewed
Jul 18, 2017
| @@ -57,6 +57,7 @@ class VisualEditor extends Component { | |||
| if ( | |||
| ! isEditableElement( document.activeElement ) && | |||
| ( event.ctrlKey || event.metaKey ) && | |||
| ! event.shiftKey && | |||
There was a problem hiding this comment.
I would prefer that we add a utility function similar to the one in TinyMCE core, because I think we'll need to do this in a few other (future) places. It's also good to describe with the function name what exactly we are blocking. In some cases this would be only the meta key, in others all modifiers. https://github.com/tinymce/tinymce/blob/4.6.4/src/core/src/main/js/util/VK.js
There was a problem hiding this comment.
Amend the PR with what you have in mind?
|
Closing in favor of #1944. |
Tug
pushed a commit
that referenced
this pull request
Feb 28, 2020
* Update release notes * Update bottomsheet scroll support * Mention about scrolling settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1850.