Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent select all behavior when shift key is pressed #1908

Closed
wants to merge 1 commit into from
Closed

Prevent select all behavior when shift key is pressed #1908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions editor/modes/visual-editor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ class VisualEditor extends Component {
if (
! isEditableElement( document.activeElement ) &&
( event.ctrlKey || event.metaKey ) &&
! event.shiftKey &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that we add a utility function similar to the one in TinyMCE core, because I think we'll need to do this in a few other (future) places. It's also good to describe with the function name what exactly we are blocking. In some cases this would be only the meta key, in others all modifiers. https://github.com/tinymce/tinymce/blob/4.6.4/src/core/src/main/js/util/VK.js

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amend the PR with what you have in mind?

event.keyCode === CHAR_A
) {
event.preventDefault();
Expand Down