-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the new media flow to the media text block #19198
Conversation
47d9458
to
b74fc82
Compare
mediaUrl: newURL, | ||
href: newHref, | ||
mediaId: undefined, | ||
sizeSlug: DEFAULT_SIZE_SLUG, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no sizeSlug
attribute in the media-text block.
export const LINK_DESTINATION_ATTACHMENT = 'attachment'; | ||
const LINK_DESTINATION_MEDIA = 'media'; | ||
const LINK_DESTINATION_ATTACHMENT = 'attachment'; | ||
const DEFAULT_SIZE_SLUG = 'large'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the default, because there is no sizeSlug
attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, works great!
Description
Requires #18139 There is a new replace flow offered by a component which is currently implemented in the Image Block. This PR implements the new flow in the Media + Text block.
How has this been tested?
Tested locally.
Screenshots