-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Back to WP button in Fullscreen Mode #20603
Conversation
Size Change: +751 B (0%) Total Size: 866 kB
ℹ️ View Unchanged
|
Nice work. The color is a bit off, the icon size is a bit off, and we should not use the icon version of the logo as that's been hinted to be shown small. Mind if I fix all of this and push straight to the branch? |
@jasmussen go for it. |
I'm trying to include a new logo SVG but getting some linting errors:
What am I missing? |
Nevermind, figured it out. Going to push a fix to the hover color and focus. In the mean time — the tooltip says "View Posts" — can you help me change that to "Go to Posts"? |
Pushed some polish: As mentioned, the label should say "Go to Posts" rather than "View Posts". The alternative design proposed in #20579 requires a bit of a different tooltip. We may want to not close that ticket with this PR, but keep it open, and then try this tooltip for starters. |
As explained in the PR description that's not possible because of the CPTs. |
Oh, apologies, I missed that! As you were, then :) |
This works as expected for me. I did notice some potential variation in drop down we might want to correct: This, however, I think is another issue. cc'ing in @jasmussen as might be due to recent updates? For now, removing design feedback label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on design.
Let's try that. |
I feel it is too late to add a new default full screen setup into WP 5.4. We should instead have time to test it out in the plugin. Lets punt it to WP 5.5. |
I like the fullscreen mode but probably won't use it. It will for be become forgotten very quickly due to the fact that the control is hidden in the drop down control. If there was a discrete control up front on the tool bar I would be more inclined to use it by default. |
Hey @irishetcher I made this issue: #20695 |
closes #20579
This PR tries to implement the proposal in 120579. It doesn't change the button label because it's CPT specific and we only have the view_items label here https://developer.wordpress.org/reference/functions/get_post_type_labels/ (potentially we could change to a more generic label like "Back to WP Admin"
The button does feel a bit prominent but maybe that's fine.