Navigation: Improve WP logo rendering (for non-retina displays) #21217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -200 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update adjusts the SVG shape of the WordPress logo for the top left navigation.
Problem
The issue before was that the thinner outer border would render at a lower quality for non-Retina displays. This is most likely due to the lines having a sub-pixel value, which makes it difficult for the browser to draw on non-Retina screens.
Solution
The solution I went with was to use the existing
wordpressicon SVG (from@wordpress/icons) instead of the custom embedded SVG component (previously).Non-Retina Rendering
Retina Rendering
The thicker border appears to be more forgiving when it comes to scaling (up or down) and rendering.
How has this been tested?
Tested locally on Gutenberg. On a non-Retina external monitor as well as a Retina external monitor.
Tested in both Chrome and Firefox
Checklist:
Resolves: #21216