Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default list type to be unordered list #2095

Merged
merged 4 commits into from
Aug 2, 2017

Conversation

BoardJames
Copy link

This pull request sets the default list type for the list block to be unordered list.

See the relevant issue here: #2053 (comment)

@codecov
Copy link

codecov bot commented Jul 31, 2017

Codecov Report

Merging #2095 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2095   +/-   ##
=======================================
  Coverage   20.34%   20.34%           
=======================================
  Files         135      135           
  Lines        4237     4237           
  Branches      722      719    -3     
=======================================
  Hits          862      862           
- Misses       2843     2845    +2     
+ Partials      532      530    -2
Impacted Files Coverage Δ
blocks/library/list/index.js 8.21% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d206e8a...e251dc9. Read the comment docs.

@BoardJames BoardJames requested a review from aduth July 31, 2017 02:58
@youknowriad
Copy link
Contributor

Can we use the defaultAttributes property instead of destructuring with default values in multiple functions?

@BoardJames
Copy link
Author

@youknowriad I am now using the defaultAttributes property. I also took the opportunity to fix the lower case nodeName values in the transforms. Any other problems?

@BoardJames BoardJames merged commit 1eb24a7 into master Aug 2, 2017
@BoardJames BoardJames deleted the update/2053-list-set-ul-default branch August 2, 2017 03:19
ceyhun pushed a commit that referenced this pull request Apr 22, 2020
…2095)

* Fix: remove extra padding for post title and first `Paragraph` block
ceyhun pushed a commit that referenced this pull request Apr 22, 2020
* Release v1.26.0 (#2153)

* Add tests for Latest-Posts Bock

* Have the Automation tests Scroll the Block window to help locate Block buttons on Android

* Update gutenberg reference

* Update Gutenberg ref

* Update Gutenberg ref

* New template for release PRs

This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`

* Update template file.

* Fix: remove extra padding for post title and first `Paragraph` block (#2095)

* Fix: remove extra padding for post title and first `Paragraph` block

* Update Gutenberg ref

* Add a new androidReplacements function to comply with Android Typography lint rules

* Make sure the file gutenberg.pot exists before generating android and ios strings.

* Update Gutenberg ref

* Update gutenberg ref

* Update gutenberg ref

* Update gutenberg reference

* Gutenberg update

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023)

* prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS

* Update Gutenberg ref

* Update Gutenberg ref

* Accept multiple headers through OnAuthHeaderRequestedListener (#2080)

* Blog layout template (#2114)

* Update Gutenberg ref

* Update Gutenberg ref

* Update gutenberg reference

* Fix failing UI tests

Try scrolling in the Inserter for all platforms

* Disable the failing test on iOS

Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>

* Update gutenberg reference

* Feat: Column block (#1661)

* update ref to master (Columns Block)

* Update gutenberg reference

* Fix Latests Posts Tests by expanding the scroll to button functionality

* Fix lint issue

* Fix typography breakage in master

To a version where the typography panel is not added to block settings.

* Update GB reference.

* Correct slider step value (#2119)

* Update ref: Correct slider step accordingly to the platform

* Update gb ref

Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>

* v1.26.0

* Add some missing release notes

* Update Podfile.lock

* Update gb ref

* Update bundles

Co-authored-by: Chip Snyder <chip.snyder3@gmail.com>
Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
Co-authored-by: jbinda <jakub.binda@gmail.com>
Co-authored-by: Chip <chip.snyder@automattic.com>
Co-authored-by: Maxime Biais <maxime.biais@gmail.com>
Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com>
Co-authored-by: Klymentiy Haykov <forsver@gmail.com>
Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>

* Update gb ref

Co-authored-by: Chip Snyder <chip.snyder3@gmail.com>
Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
Co-authored-by: jbinda <jakub.binda@gmail.com>
Co-authored-by: Chip <chip.snyder@automattic.com>
Co-authored-by: Maxime Biais <maxime.biais@gmail.com>
Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com>
Co-authored-by: Klymentiy Haykov <forsver@gmail.com>
Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Tug added a commit that referenced this pull request May 12, 2020
* Add tests for Latest-Posts Bock

* Have the Automation tests Scroll the Block window to help locate Block buttons on Android

* Update gutenberg reference

* Update Gutenberg ref

* Update Gutenberg ref

* New template for release PRs

This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`

* Update template file.

* Fix: remove extra padding for post title and first `Paragraph` block (#2095)

* Fix: remove extra padding for post title and first `Paragraph` block

* Update Gutenberg ref

* Add a new androidReplacements function to comply with Android Typography lint rules

* Make sure the file gutenberg.pot exists before generating android and ios strings.

* Update Gutenberg ref

* Update gutenberg ref

* Update gutenberg ref

* Update gutenberg reference

* Gutenberg update

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023)

* prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS

* Update Gutenberg ref

* Update Gutenberg ref

* Accept multiple headers through OnAuthHeaderRequestedListener (#2080)

* Blog layout template (#2114)

* Update Gutenberg ref

* Update Gutenberg ref

* Update gutenberg reference

* Fix failing UI tests

Try scrolling in the Inserter for all platforms

* Disable the failing test on iOS

Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>

* Update gutenberg reference

* Feat: Column block (#1661)

* update ref to master (Columns Block)

* Update gutenberg reference

* Fix Latests Posts Tests by expanding the scroll to button functionality

* Fix lint issue

* Fix typography breakage in master

To a version where the typography panel is not added to block settings.

* Update GB reference.

* Correct slider step value (#2119)

* Update ref: Correct slider step accordingly to the platform

* Update gb ref

Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>

* v1.26.0

* Add some missing release notes

* Update Podfile.lock

* Update gb ref

* Update bundles

Co-authored-by: Chip Snyder <chip.snyder3@gmail.com>
Co-authored-by: Matthew Kevins <mmkevins@yahoo.com>
Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
Co-authored-by: jbinda <jakub.binda@gmail.com>
Co-authored-by: Chip <chip.snyder@automattic.com>
Co-authored-by: Maxime Biais <maxime.biais@gmail.com>
Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com>
Co-authored-by: Klymentiy Haykov <forsver@gmail.com>
Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants