Upgrade React version to 16.13.1 #21289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ajitbohra,
jorgefilipecosta and
TimothyBJacobs
as code owners
|
Size Change: +132 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
gziolo
added
[Package] Element
6 tasks
youknowriad
commented
May 2, 2020
|
On the native mobile side, there's WIP effort to upgrade to RN v0.62.x which depends on React Not sure if the native mobile side can upgrade 16.13.1 or not. @marecar3 , can you quickly try 16.13.1 on the RN 0.62 upgrade branch to see if it's compatible? In the meantime, is the bump to .13 imperative at this stage @youknowriad, or can it wait? |
|
@hypest we don't intend to merge this PR soon, I opened it to track the incompatibility issue above but It's a good idea to start testing mobile too so we're ready |
youknowriad
force-pushed
the
upgrade/react-16.3.1
branch
from
7a21ad7 to
dc48adb
Compare
youknowriad
requested review from
spacedmonkey,
chrisvanpatten,
gziolo and
ntwb
as code owners
youknowriad
force-pushed
the
upgrade/react-16.3.1
branch
from
52a5069 to
dc2c833
Compare
youknowriad
force-pushed
the
upgrade/react-16.3.1
branch
from
4603edd to
b432d01
Compare
youknowriad
force-pushed
the
upgrade/react-16.3.1
branch
from
b432d01 to
209d94f
Compare
|
Seems like there's just one unit test failure and then we'll be able to merge. |
youknowriad
added
the
Framework
|
Thanks for the headsup @youknowriad ! 👋 @ceyhun , would you mind taking this PR for a spin to also check manually if the native apps work as normal? Thanks! |
|
Thanks for the fix @ItsJonQ |
Merged
2 tasks
ceyhun
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
Gave this a spin running demo apps both from gutenberg and gutenberg-mobile and playing around a bit, seemed OK.
Also ran full suite of E2E tests on gutenberg-mobile and they were green ✅
There appeared to be a package-lock.json diff in gutenberg-mobile which I'll be pushing to the gutenberg-mobile PR.
|
Great, thanks :) Let's ship that. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21049
Upgrade React to 16.13.1. This new version has a new warning preventing side effects during rendering phase. This PR solves these warnings for the data module (resolvers) and for the BoxControl component.