Only scroll page for multi-selections #21460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
ellatrix
reviewed
Apr 7, 2020
| if ( | ||
| ! selectionEnd || | ||
| isMultiSelecting || | ||
| selectionEnd === selectionStart |
There was a problem hiding this comment.
How about using the hasMultiSelection selector?
There was a problem hiding this comment.
yes, this works too
|
Size Change: +13 B (0%) Total Size: 889 kB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
fix/multi-selection-scroll-into-view
branch
from
dee19ba
to
170b71e
Compare
ellatrix
approved these changes
Apr 7, 2020
whyisjake
pushed a commit
that referenced
this pull request
Apr 22, 2020
whyisjake
pushed a commit
that referenced
this pull request
Apr 22, 2020
whyisjake
pushed a commit
that referenced
this pull request
Apr 23, 2020
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19682
closes #21432
It seems that this component "MultiSelectScrollIntoView" has been refactored during the WP 5.4 lifecycle and it was triggering for simple selections too.
I'm not 100% certain this is the right fix but right now it only triggers for multi selections fixing this important bug #19682