WordPress 5.4.1 Backports #21800
WordPress 5.4.1 Backports #21800
Conversation
Co-authored-by: roo2 <roo2@protonmail.com>
whyisjake
requested review from
ajitbohra,
ellatrix,
jorgefilipecosta,
nerrad,
ntwb,
Soean,
talldan and
youknowriad
as code owners
Including all of the vars, while we really only need one.
|
@jorgefilipecosta this is ready to go. I had to add the grid system in that last commit. |
|
@whyisjake, is there context behind adding commit a0d2c64? |
|
Thanks, that makes sense. Edit: I've updated the PR description to reflect the role of a0d2c64 |
|
Looks good overall, but @youknowriad could you confirm for Fix keyboard block duplication (#21317)? I'm not sure about the testing instructions (cmd+shift+enter to duplicate?). |
|
I confirm duplication using the keyboard shortcut works in this PR, it was broken before (JS error) |
| @@ -1,7 +1,14 @@ | |||
| .wp-block-buttons .wp-block-button { | |||
| display: inline-block; | |||
| margin: $grid-size-small; | |||
| margin-right: $grid-unit-10; | |||
There was a problem hiding this comment.
During previous cherry-picks (e.g: during 5.4 RC) we opted for not include the new grid system and just change the variable to their equivalents e.g: $grid-unit-10 would be $grid-size in the "old system". But in retrospective probably including the grid system from the start would have been a safer and easier choice, so I don't have anything against including the new grid variables (I regret not having done it sooner). cc: @youknowriad in case you think including the grid system may have an undesirable side effect in future cherry-picks.
There was a problem hiding this comment.
I think it's fine to include it, it's harmless
Description
Bringing in the following changes:
imageDimensionsis empty (Fix the latest-posts block whenimageDimensionsis empty #21070) …These tickets are form this label: Backport to WP Core