Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles: Convert px values to rem #22505

Closed
wants to merge 6 commits into from

Conversation

aristath
Copy link
Member

Description

This was discussed in today's block-themes meeting and with the blessings of the team I'm starting a PR to slowly begin converting all styles to use relative units instead of absolute.

Please note: This is still a WIP.

Including @mapk as discussed in the meeting. This is a task that will probably require some coordination.

How has this been tested?

Hasn't been tested.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@aristath
Copy link
Member Author

aristath commented Aug 4, 2020

Closing this one.
Instead of a huge PR it's preferable to do smaller ones and iterate as we go.
Smaller PRs have already been pushed and more are on the way.
(see #17076, #24322, #24323, #24330)

@aristath aristath closed this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant