Paragraph block: Use relative instead of absolute units #24330
Conversation
| p.has-background { | ||
| padding: $block-bg-padding--v $block-bg-padding--h; | ||
| padding: 1.25em 2.375em; | ||
| } |
There was a problem hiding this comment.
This is the only change I'm not sure of. If we want to change this, shoudn't we change it at the variable itself? Should we even change it in the first place?
There was a problem hiding this comment.
Yeah, this part was also troubling me a bit... so I pushed it as a point for discussion.
If users add a small-text, should it have smaller padding than a large-text? If yes, then em values make sense. If on the other hand we want consistent paddings that don't depend on the font-size, then em doesn't make sense and could be changed to rem values.
The reason I didn't change the variables themselves is because they are used in other blocks as well (columns & heading) and the change would affect more styles than intended. 🤔
If the padding change is a blocker for this PR I can just remove it and bring it up in a meeting for further discussion.
ZebulanStanphill
added
[Block] Paragraph
|
End-to-end test failure is intermittent and unrelated. See #24336. |
|
Combined with other PRs in #24523 |
This PR converts the paragraph block to use
remvalues instead ofpx.This will provide better compatibility with themes that use a different base font-size, as lately we're seeing a tendency to use a base font-size of 20px+.
With these changes in place, themes won't need to rewrite all CSS and can just use what's provided by core.
Checklist:
My code has proper inline documentation.(Not applicable)I've included developer documentation if appropriate.(Not applicable)I've updated all React Native files affected by any refactorings/renamings in this PR.(Not applicable)