Author: Show only users capable of authoring posts #2525
Conversation
aduth
added
the
General Interface
Codecov Report
@@ Coverage Diff @@
## master #2525 +/- ##
==========================================
+ Coverage 30.2% 30.57% +0.36%
==========================================
Files 174 174
Lines 5270 5263 -7
Branches 900 897 -3
==========================================
+ Hits 1592 1609 +17
+ Misses 3121 3101 -20
+ Partials 557 553 -4
Continue to review full report at Codecov.
|
editor/sidebar/post-author/index.js
Outdated
| }, | ||
| }, | ||
| )( withInstanceId( PostAuthor ) ); | ||
| } ), |
There was a problem hiding this comment.
Do you think we should enforce a convention here, something like this;
const connectComponent = connect( ... );
const fetchAPIData = withApiData( ... );
export default flowRight( [
connectComponent,
fetchAPIData,
] )( Component );There was a problem hiding this comment.
Maybe. Naming things is hard 😄 For example, the API data higher-order component doesn't necessarily incur a fetch (might be used only for updating), and itself doesn't perform the fetch. All it does is apply a wrapping (higher-order) component.
I think if we were to, we'd want some easy convention for naming, like a consistent prefix. Maybe "apply": applyConnect, applyWithAPIData
There was a problem hiding this comment.
sound good to me. I'll follow the convention chosen here in my PRs
There was a problem hiding this comment.
Out of curiosity, what's your reason for wanting a convention here? Are you finding this could be difficult to interpret?
There was a problem hiding this comment.
My primary reason is to avoid indentation changes when moving from one HoC to composed HOCs. But I also find it more readable.
aduth
force-pushed
the
update/user-author-permissions
branch
from
6c82952 to
e0f11fb
Compare
Related: #2029
Closes #2491
Closes #2157
Fixes #2524
This pull request seeks to account for user capabilities in deciding which options to show in the Author select dropdown. It also refactors the component to use the
withAPIDatahigher-order component introduced in #1974, fixes an issue with author selection permanently causing a post to be flagged as dirty, and adds unit tests.Testing instructions:
Repeat testing instructions from #2100