Featured Image: Refactor Featured Image to use withApiData HoC
#2527
Conversation
youknowriad
added
the
General Interface
Codecov Report
@@ Coverage Diff @@
## master #2527 +/- ##
==========================================
+ Coverage 28.49% 30.04% +1.54%
==========================================
Files 169 174 +5
Lines 5148 5505 +357
Branches 859 981 +122
==========================================
+ Hits 1467 1654 +187
- Misses 3119 3234 +115
- Partials 562 617 +55
Continue to review full report at Codecov.
|
|
The |
| onSelect={ onUpdateImage } | ||
| type="image" | ||
| > | ||
| { media && !! media.data && |
There was a problem hiding this comment.
media should always be an object assigned by withAPIData, so shouldn't need to test truthiness (except for testing convenience).
There was a problem hiding this comment.
Yeah, but sometimes I don't assign the media prop at all in the HoC. (When there's no image set)
There was a problem hiding this comment.
True. In this particular case since we're already in the condition of !! featuredImageId that would never apply, but probably good to be safe.
| @@ -135,4 +79,19 @@ export default connect( | |||
| }, | |||
| }; | |||
| } | |||
| ); | |||
|
|
|||
| const fetchAPIData = withAPIData( ( { featuredImageId } ) => { | |||
There was a problem hiding this comment.
Do we want to use the naming convention discussed at #2525 (comment) ?
There was a problem hiding this comment.
Sure, I was waiting for your changes there :). Updating
In this PR, I'm trying to use
withAPIDatain the featured image component and this is a huge improvement over repeating the same lifecycle calls over and over again :)I've noticed a bug and I suspect that the HoC doesn't trigger the requests properly when the URL changes. I may be wrong though. (Try changing the featured image, the new one is not fetched) Any idea @aduth