Block Directory: Switch to blocks.registerBlockType filter
#25264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us avoid adding a new filter specific to the missing block
ryelle
added
the
[Feature] Block Directory
|
Size Change: -721 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
|
I was unable to get the "Keep as HTML" link working. I click the link but nothing happens. |
|
@StevenDufresne Good catch — with the new filter that function isn't passed down into the component, so I need to define it here, too. Should be fixed with 1acd239 |
StevenDufresne
approved these changes
Sep 21, 2020
| let messageHTML = sprintf( | ||
| /* translators: %s: block name */ | ||
| __( | ||
| 'Your site doesn’t include support for the %s block. You can try installing the block or remove it entirely.' |
There was a problem hiding this comment.
It would be nice if we could add a button to remove the block, although not a blocker for this PR.
There was a problem hiding this comment.
Actually, my comment is with the original block, not this one.
There was a problem hiding this comment.
Yeah, it is following the pattern from the original core/missing block. I think the idea is that you'd remove it like any other block (click and hit delete, or use the toolbar menu to remove it), but you could open an issue about it if you think we need a button here.
There was a problem hiding this comment.
Note that this string interpolation won't work for all locales.
There isn't much else to do — it's more of an FYI — especially since the translators note is already there. Some translations may work around their issues by rephrasing as e.g. "%s: Your site doesn't include support for this block."
mcsf
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #22631 functionality was added to detect and install missing blocks from the block directory, if available. Initially this created a new filter on
MissingEdit, but after some discussion on the PR, it was suggested to use the existingblocks.registerBlockTypefilter instead. This PR makes the switch & removes theeditor.missingEditfilter.This also updates the message displayed to the user— it won't offer HTML conversion if the missing block has no content or the HTML block is disabled.
How has this been tested?
Manual testing, using the following code to trigger a request to install the Star Rating block
You can test the no HTML case with this block code:
Screenshots