Block Directory: Fix "missing" block when the block can be installed from the directory #28030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
added
the
[Feature] Block Directory
|
Size Change: +110 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When blocks were updated to use API v2/
useBlockProps, it caused a bug with the modified missing block. See #25264 & #22631 for history, but basically if a missing block is found in the block directory, we modify the "Missing" message to let users install that block. When the block API was changed, the wrapper no longer applied correctly to the modified message, and it caused the breaking described in #27916 & #27287.Fixes #27916.
How has this been tested?
Manual testing, using the following code to trigger a request to install the Star Rating block
You can test the no HTML case with this block code:
Once the "Install Start Rating" button shows up, you should be able to click the missing block container. It should highlight, show the block toolbar, and you should be able to delete it.
Types of changes
Bug fix (non-breaking change which fixes an issue)