[RNMobile] Improve AztecWrapper RN talkback support #25384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-alexander
changed the title
|
@cameronvoell @mchowning could you please add the relevant labels here for me 😄 |
jd-alexander
changed the title
mchowning
added
the
Mobile App - i.e. Android or iOS
2 tasks
mchowning
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
Tested and working well. LGTM!
I also ran through the test steps for wordpress-mobile/gutenberg-mobile#1076 (which is the PR that added the aztecText.setFocusable(false) line in order to check for regressions, and I did not observe any problems. 👍
guarani
approved these changes
Sep 18, 2020
|
@guarani could you merge this for me. Thanks 🙏 |
github-actions
bot
added
the
First-time Contributor
|
Done @jd-alexander ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#918
Aztec Android PR wordpress-mobile/AztecEditor-Android#927
Gutenberg Mobile PR wordpress-mobile/gutenberg-mobile#2630
Description
Currently the RichText will focus automatically without needing double tapping. This was taking place due to the
AccessibilityDelegateinAztecrequesting focus on hover, so that behavior was removed. This PR, resolves this by utilizing the mentioned fix within Aztec along with enabling theRichTextcomponent via theReactAztecManagerso that thedouble-tap to activatebehavior becomes active.Testing
This was first tested in Aztec by ensuring that the
AztecTextview no longer auto focuses on hover. The commit hash of the Aztec PR was then utilized within Gutenberg to verify that the editor would no longer perform this auto-focusing.For further testing here are the instructions.
RichTextsuch as a paragraph block.Screenshots
Video Example
Concerns
The only change made in this PR I was wondering about is the removal of
setFocusable(false)I tried to utilize git blame to figure out why this was added in the first place but I wasn't able to find a commit with enough details, hence I am pointing it out here.Update this was being discussed here as well. I will look into it more.
Checklist:
Review