Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AztecWrapper RN talkback support #2630

Merged

Conversation

jd-alexander
Copy link
Contributor

Fixes #918

Related PRs
Gutenberg PR WordPress/gutenberg#25384
Aztec Android PR wordpress-mobile/AztecEditor-Android#927

Description

Currently the RichText will focus automatically without needing double tapping. This was taking place due to the AccessibilityDelegate in Aztec requesting focus on hover, so that behavior was removed. This PR, resolves this by utilizing the mentioned fix within Aztec along with enabling the RichText component via the ReactAztecManager so that the double-tap to activate behavior becomes active.

Testing

Follow testing instructions here WordPress/gutenberg#25384
PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! 👍

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 18, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@jd-alexander jd-alexander merged commit db8949e into develop Sep 24, 2020
@jd-alexander jd-alexander deleted the issue-918/improve_aztec_wrapper_talkback_support branch September 24, 2020 18:08
@cameronvoell cameronvoell mentioned this pull request Sep 29, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve AztecWrapper RN TalkBack support.
2 participants