Limit NPM compatible version to be below 7 #29000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
|
Do we still need this, now that npm 7.5.3 is out, and #28890 seems to fix the issue with Appium? |
2 tasks
Oh I didn't realised that there's a new NPM version 🎊 . I'll check it out but if it works with the Appium update we don't need this PR. |
Not sure why but looks like the CI is still failing with latest NPM version, you can check it in a PR I created that updates the lock file format version of I saw that NPM released recently a new version |
7 tasks
|
Thank you for making this! I also made a PR before I noticed this: #29204, it also tries to fix the
I believe we still need it until npm fixes npm/cli#2610. |
Thanks! Since your PR covers also the
Good catch, I'm not sure if there're more cases affected by this issue but I managed to fix the ones located in the package |
I've approved and merged that other PR 😄 I'll close this one. Thanks all! |
Didn't know that there's a workaround for that! Seems like that there are other issues though 😅 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #28834, we have a dependency that is producing an error when running
npm installwith NPM version 7. Since this issue is coming from NPM, until a fix is released we could limit the use of NPM to version 6.For this purpose, the PR adds a condition in the engine property of
package.jsonfile to set the version compatibility of NPM below 7.Documentation about the engine parameter: https://docs.npmjs.com/cli/v6/configuring-npm/package-json#engines
How has this been tested?
Verify that dependencies are installed with NPM version 6
npm install -g npm@6.npm install.Verify that dependencies are not installed and fails with NPM version 7
npm install -g npm@7.npm install.Screenshots
Types of changes
Bug fix
Checklist: