Limit the npm version to be 6 #29204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
kevin940726
commented
Feb 22, 2021
|
|
||
| /** | ||
| * Returns a promise resolving with the version number of the latest available | ||
| * version of NPM. | ||
| * version of npm. |
There was a problem hiding this comment.
Changed from NPM to npm since it's actually supposed to be all-lowercase 😅 .
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
7 tasks
ockham
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Thanks @kevin940726! This should allow us to sidestep the npm 7 conundrum.
The check-latest-npm fix is great and aligns with what we seem to have reached agreement for on #29097 👍
5 tasks
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Sep 11, 2022
Using NPM 7+ currently causes a number of issues. In order to improve developer experience, we should prevent a developer from going down the road of using incompatible engines. See also: WordPress/gutenberg#29204 and WordPress/gutenberg#23600. Props rcorrales. Fixes #56547. git-svn-id: https://develop.svn.wordpress.org/trunk@54124 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Sep 11, 2022
Using NPM 7+ currently causes a number of issues. In order to improve developer experience, we should prevent a developer from going down the road of using incompatible engines. See also: WordPress/gutenberg#29204 and WordPress/gutenberg#23600. Props rcorrales. Fixes #56547. Built from https://develop.svn.wordpress.org/trunk@54124 git-svn-id: http://core.svn.wordpress.org/trunk@53683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Sep 11, 2022
Using NPM 7+ currently causes a number of issues. In order to improve developer experience, we should prevent a developer from going down the road of using incompatible engines. See also: WordPress/gutenberg#29204 and WordPress/gutenberg#23600. Props rcorrales. Fixes #56547. Built from https://develop.svn.wordpress.org/trunk@54124 git-svn-id: https://core.svn.wordpress.org/trunk@53683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
whereiscodedude
pushed a commit
to whereiscodedude/wpss
that referenced
this pull request
Sep 18, 2022
Using NPM 7+ currently causes a number of issues. In order to improve developer experience, we should prevent a developer from going down the road of using incompatible engines. See also: WordPress/gutenberg#29204 and WordPress/gutenberg#23600. Props rcorrales. Fixes #56547. Built from https://develop.svn.wordpress.org/trunk@54124
ootwch
pushed a commit
to ootwch/wordpress-develop
that referenced
this pull request
Nov 4, 2022
Using NPM 7+ currently causes a number of issues. In order to improve developer experience, we should prevent a developer from going down the road of using incompatible engines. See also: WordPress/gutenberg#29204 and WordPress/gutenberg#23600. Props rcorrales. Fixes #56547. git-svn-id: https://develop.svn.wordpress.org/trunk@54124 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An alternative to #29000.
As pointed out in #28824, we don't currently support npm 7 until they fix npm/cli#2610. As a temporary fix, we should limit the npm version to 6 for now.
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: