Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated: Add since option to deprecated function #30017

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

Mamaduka
Copy link
Member

Description

Adds the ability to specify the version of the Gutenberg/WordPress in which the feature was deprecated.

I'm also working on separated PR to fill in the since option for deprecated function calls in the codebase.

Fixes #23373.

How has this been tested?

Using test-unit script.

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • [N/A] My code follows the accessibility standards.
  • [N/A] I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • [N/A] I've updated all React Native files affected by any refactorings/renamings in this PR.

@Mamaduka Mamaduka self-assigned this Mar 19, 2021
@Mamaduka Mamaduka added [Package] Deprecated packages/deprecated [Type] Enhancement A suggestion for improvement. labels Mar 19, 2021
@gziolo gziolo added the [Type] New API New API to be used by plugin developers or package users. label Mar 19, 2021
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some formatting issues to fix but overall it looks like a nice addition 👍🏻

@gziolo gziolo requested a review from desrosj March 19, 2021 12:40
@Mamaduka
Copy link
Member Author

Thanks, @gziolo for the review. I just pushed fixes for the formatting issues.

@gziolo
Copy link
Member

gziolo commented Mar 19, 2021

Cool, feel free to merge once CI is green 👍🏻

@Mamaduka
Copy link
Member Author

Cool, feel free to merge once CI is green 👍🏻

Sorry, forgot that I'm not authorized to merge pull requests.

@gziolo gziolo merged commit a4b2b42 into WordPress:trunk Mar 19, 2021
@github-actions github-actions bot added this to the Gutenberg 10.3 milestone Mar 19, 2021
@gziolo
Copy link
Member

gziolo commented Mar 19, 2021

Cool, feel free to merge once CI is green 👍🏻

Sorry, forgot that I'm not authorized to merge pull requests.

@youknowriad, can you fix it? 😄

I see 4 merged commits: https://github.com/WordPress/gutenberg/commits?author=Mamaduka

@youknowriad
Copy link
Contributor

It's fixed :)

@Mamaduka
Copy link
Member Author

Thank you, @gziolo, @youknowriad!

@Mamaduka Mamaduka deleted the update/deprecated-add-since-option branch March 22, 2021 02:52
@gziolo gziolo removed the [Type] Enhancement A suggestion for improvement. label Mar 31, 2021
@gziolo gziolo changed the title Add 'since' option to deprecated function Deprecated: Add since option to deprecated function Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Deprecated packages/deprecated [Type] New API New API to be used by plugin developers or package users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to specify the version a function was deprecated
3 participants