-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated: Add since
option to deprecated
function
#30017
Deprecated: Add since
option to deprecated
function
#30017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some formatting issues to fix but overall it looks like a nice addition 👍🏻
Thanks, @gziolo for the review. I just pushed fixes for the formatting issues. |
Cool, feel free to merge once CI is green 👍🏻 |
Sorry, forgot that I'm not authorized to merge pull requests. |
@youknowriad, can you fix it? 😄 I see 4 merged commits: https://github.com/WordPress/gutenberg/commits?author=Mamaduka |
It's fixed :) |
Thank you, @gziolo, @youknowriad! |
since
option to deprecated
function
Description
Adds the ability to specify the version of the Gutenberg/WordPress in which the feature was deprecated.
I'm also working on separated PR to fill in the
since
option for deprecated function calls in the codebase.Fixes #23373.
How has this been tested?
Using
test-unit
script.Types of changes
Checklist: