Add 'since' versions to the deprecated features

[Mamaduka]

Description

This is a follow-up of #30017 and adds deprecation versions to the features.

I've used a combination of git history, Github milestones, and inline comments to track down deprecation versions.

How has this been tested?

Locally by using the deprecated features. Example:

wp.data.select( 'core/editor' ).getSelectedBlock();

Calling the following selector in the console should result in a deprecation message with a version it was deprecated.

Types of changes

New feature

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• [N/A] My code follows the accessibility standards.
• [N/A] I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• [N/A] I've updated all React Native files affected by any refactorings/renamings in this PR.

[gziolo]

I'm wondering how valuable those versions are without context. They should make it clear that this version is related to the plugin:

plugin: 'Gutenberg',

Aside: For folks consuming the block editor from the WordPress core, this information might be less useful as they would rather prefer seeing the version of WordPress core.

[Mamaduka]

Hi @gziolo,

I also would prefer seeing the WP version in those messages. As a plugin developer, it would make it easier for me to check if the suggested alternative will work with my minimum required WP version.

Maybe we should use the WP version in log messages and add the Gutenberg version in DocBlocks.

P.S. I remember there was a document with a list, which WP version included which Gutenberg version. But I'm not able to find it right now.

[gziolo]

P.S. I remember there was a document with a list, which WP version included which Gutenberg version. But I'm not able to find it right now.

You can open a file and switch to the branch for a given WP version, e.g.:

https://github.com/WordPress/gutenberg/blob/wp/5.7/packages/block-editor/src/components/block-card/index.js
vs
https://github.com/WordPress/gutenberg/blob/wp/5.6/packages/block-editor/src/components/block-card/index.js

[gziolo]

So we could default to the Gutenberg version in the code when introducing a deprecation and update them just before every major WordPress release. How does it sound? It would give good feedback on where the deprecation comes from.

[Mamaduka]

So we could default to the Gutenberg version in the code when introducing a deprecation and update them after every major WordPress release. How does it sound? It would give good feedback on where the deprecation comes from.

Sounds great. I will update PR to use WP versions.

[Mamaduka]

@gziolo I've updated since options for deprecated features that are part of the core to use WP versions.

[gziolo]

There are some places where it would be valuable to explicitly say that the since comes from the Gutenberg plugin. Otherwise, nice improvements 👍🏻

[Mamaduka]

Thanks, @gziolo for the suggestion.

I provided a plugin option for Gutenberg deprecations and removed them from WP ones.

[gziolo]

All good 🚢

[gziolo]

https://github.com/WordPress/gutenberg/tree/trunk/docs/how-to-guides/backward-compatibility#deprecations

The last step would be to update the documentation and share recommendations on how to use deprecation helper moving on. There is this section that could be extended:

https://github.com/WordPress/gutenberg/tree/trunk/docs/how-to-guides/backward-compatibility#deprecations

[Mamaduka]

The last step would be to update the documentation and share recommendations on how to use deprecation helper moving on. There is this section that could be extended:

Sounds good. I will create a separate PR for this if it's okay with you.

[gziolo]

Sounds good. I will create a separate PR for this if it's okay with you.

Yes, for sure 👍🏻