Don't show the classic editor dropdown on unsupported post types. #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pento
added
Gutenberg Plugin
aduth
approved these changes
Oct 25, 2017
| $post_type = $post->post_type; | ||
| $post_type_object = get_post_type_object( $post_type ); | ||
|
|
||
| if ( 'attachment' === $post_type ) { |
There was a problem hiding this comment.
Noting that we're no longer checking this in gutenberg_can_edit_post_type, and while I don't know the original reason why we were explicitly targeting attachment, my understanding is this should still be effective since post_type_supports( 'attachment', 'editor' ) === false.
There was a problem hiding this comment.
Yah, that's why I dropped it, it was an unnecessary extra check. :-)
pento
deleted the
fix/classic-editor-dropdown-showing-on-unsupported-post-types
branch
pento
added a commit
that referenced
this pull request
Oct 26, 2017
pento
added a commit
that referenced
this pull request
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The editor selector dropdown on the post list table shows on post types that aren't supported, which isn't ideal.
This PR addresses that, as well as tidies up some of the post and post type checks that are used to decide whether Gutenberg can edit the post or post type.