Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a failing unit test after #3146 #3162

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Conversation

pento
Copy link
Member

@pento pento commented Oct 26, 2017

#3146 introduced a change that caused a unit test to fail.

@pento pento added the [Type] Bug An existing feature does not function as intended label Oct 26, 2017
@pento pento self-assigned this Oct 26, 2017
@codecov
Copy link

codecov bot commented Oct 26, 2017

Codecov Report

Merging #3162 into master will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3162      +/-   ##
=========================================
- Coverage   31.63%   31.1%   -0.53%     
=========================================
  Files         217     217              
  Lines        6275    6452     +177     
  Branches     1116    1177      +61     
=========================================
+ Hits         1985    2007      +22     
- Misses       3606    3705      +99     
- Partials      684     740      +56
Impacted Files Coverage Δ
blocks/editable/format-toolbar/index.js 5.19% <0%> (-1.19%) ⬇️
blocks/editable/index.js 11.96% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21258ac...4ba0686. Read the comment docs.

@pento pento merged commit 663b11f into master Oct 26, 2017
@youknowriad youknowriad deleted the fix/failing-unit-test-after-3146 branch October 26, 2017 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant