Framework: Upgrade ESLint dependencies #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
Codecov Report
@@ Coverage Diff @@
## master #3187 +/- ##
=======================================
Coverage 31.56% 31.56%
=======================================
Files 221 221
Lines 6311 6311
Branches 1121 1121
=======================================
Hits 1992 1992
Misses 3631 3631
Partials 688 688
Continue to review full report at Codecov.
|
Recommended combobox aria-controls is non-configurable and may recommend a poorer experience. See: #469 See: http://www.heydonworks.com/article/aria-controls-is-poop
aduth
force-pushed
the
update/eslint-4-x
branch
from
7d9abbd to
f5a3622
Compare
|
I'm going to merge this sooner than later to avoid combatting constant merge conflicts. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to upgrade ESLint dependencies to their latest versions. This brings some improvements to capturing false negatives and in some cases stricter rules. Upgrading eslint-config-wordpress brings with it some additional rules, some of which are respected here (multi-line ternaries) and some disabled (yoda which, until recently, was optional; probably worth a chat about).
Implementation notes:
Most changes should be purely cosmetic, except:
refwhich was applied and used in tests. These tests fail already in master and may arguably be better off removed since they're skipped except when passing an environment variable. I did my best to restore basic functionality. As far as I can tell, the ref was not used anywhere except in these tests.Testing instructions:
Verify that no errors or warnings are logged on lint:
Review code to verify all renamings are broadly applied, and no regressions occur in basic usage of the editor application.