Framework: Reinstate stricter ESLint rules #3206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3187
This pull request seeks to reinstate a handful of ESLint rules which were turned off as a result of ESLint dependency upgrades in #3187. Specifically, the WordPress ESLint configuration no longer enforces the following rules after WordPress-Coding-Standards/eslint-config-wordpress@b2688d6:
eqeqeq
no-undef
no-caller
no-unused-expressions
no-unused-vars
no-eq-null
one-var
For all but the last of these, we want enforcement, so these have been reinstated here. In my testing,
no-eq-null
is redundant witheqeqeq
.Testing instructions:
Verify that there are no lint issues:
cc @ntwb