Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Reinstate stricter ESLint rules #3206

Merged
merged 2 commits into from
Oct 27, 2017
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Oct 27, 2017

Related: #3187

This pull request seeks to reinstate a handful of ESLint rules which were turned off as a result of ESLint dependency upgrades in #3187. Specifically, the WordPress ESLint configuration no longer enforces the following rules after WordPress-Coding-Standards/eslint-config-wordpress@b2688d6:

For all but the last of these, we want enforcement, so these have been reinstated here. In my testing, no-eq-null is redundant with eqeqeq.

Testing instructions:

Verify that there are no lint issues:

npm run lint

cc @ntwb

@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label Oct 27, 2017
aduth added 2 commits October 27, 2017 10:57
Surfaced again by reintroduction of stricter ESLint rules
@aduth aduth force-pushed the update/eslint-stricter-rules branch from 45009ee to 0d67a84 Compare October 27, 2017 14:58
@aduth aduth merged commit 3b601b5 into master Oct 27, 2017
@aduth aduth deleted the update/eslint-stricter-rules branch October 27, 2017 15:18
@codecov
Copy link

codecov bot commented Oct 27, 2017

Codecov Report

Merging #3206 into master will decrease coverage by 0.17%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3206      +/-   ##
==========================================
- Coverage   31.43%   31.26%   -0.18%     
==========================================
  Files         222      222              
  Lines        6333     6369      +36     
  Branches     1125     1134       +9     
==========================================
  Hits         1991     1991              
- Misses       3650     3677      +27     
- Partials      692      701       +9
Impacted Files Coverage Δ
editor/modes/visual-editor/block-list.js 0% <0%> (ø) ⬆️
editor/sidebar/index.js 0% <0%> (ø) ⬆️
editor/layout/index.js 0% <0%> (ø) ⬆️
editor/header/index.js 0% <0%> (ø) ⬆️
editor/modes/text-editor/index.js 0% <0%> (ø) ⬆️
editor/modes/visual-editor/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b05c5d...0d67a84. Read the comment docs.

aduth added a commit that referenced this pull request Oct 27, 2017
@aduth
Copy link
Member Author

aduth commented Oct 27, 2017

Missed adding back no-undef, committed to master in b548a83.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant