Mobile Release v1.54.0 #32297
Merged
Mobile Release v1.54.0 #32297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhnstn
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.85 MB ℹ️ View Unchanged
|
4 tasks
dcalhoun
approved these changes
May 28, 2021
|
I noticed that there's no |
Whoops. Yes, for better or worse it is not an explicit task in the release scenario. It is a checklist item on the GB Mobile PR itself. However, it lists two locations in one task. I have overlooked the second location myself multiple times. It may be worth splitting the locations into two separate tasks in the PR.
|
|
Yeah, I was thinking of adding an extra step in the Release Checklist Template to make this step clearer, wdyt? |
I'm torn. It's a long checklist. 😄 However, having checklists in multiple locations isn't a great aspect either. 🙃 At this point, I definitely think we need to split the two locations into separate tasks. If we add those tasks to the release scenario checklist, then I think we should remove them from the PR checklist. Having the same task in two locations would likely lead to people overlooking tasks they think they already completed due to repetition/noise. |
You're right, it's getting too long to keep adding items 😄 , let's try to avoid it 👍 .
I'm leaning more on the option of splitting the two locations into separate tasks to make it clearer. EDIT: I've just realized that the change has to be done in the release pull request template. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release 1.54.0 of the react-native-editor and Gutenberg-Mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3559
Checklist:
*.native.jsfiles for terms that need renaming or removal).