Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.54.0 #3559

Merged
merged 139 commits into from
May 28, 2021
Merged

Release 1.54.0 #3559

merged 139 commits into from
May 28, 2021

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented May 28, 2021

Release for Gutenberg Mobile 1.54.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.
  • Test the Unsupported Block Editor on WP Apps (see steps).
  • Sanity test suites for WP Apps should be completed for each platform.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

jd-alexander and others added 30 commits January 20, 2021 13:54
# Conflicts:
#	bundle/ios/App.js
#	bundle/ios/App.js.map
#	bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/en-gb.json
#	bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/nl.json
#	bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/ro.json
#	bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/sv.json
# Conflicts:
#	bundle/ios/App.js
#	bundle/ios/App.js.map
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 28, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@mkevins
Copy link
Contributor

mkevins commented May 28, 2021

Writing Flow checklist (Android)

Performed via this PR build on a Pixel 3a (physical device).

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • ❌ TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@geriux
Copy link
Contributor

geriux commented May 28, 2021

🟢 Sanity test - Test Suite 1

Using the build #49135.
Device: iPhone 12 Pro

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • ❌ Gallery block - Add Gallery Image Caption - TC04
  • Known issue Toolbar options disappear while switching between captions inside a gallery
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Columns percentage mechanism - column's preview - TC019
  • Columns - Columns percentage mechanism - column's slider input - TC020
  • Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- TC021
  • Columns percentage mechanism - custom percentage values are rendered correctly on frontend- TC022
  • Columns - Multiple slider in columns parent - TC023
  • Columns - Adding Column with AppenderButton - TC003
  • Columns - Adding and removing Column with BottomSheet Stepper control - TC004

Columns - 2

  • Columns - Max limit of Column number - TC005
  • Columns - Min limit of Column number - TC006
  • Columns - Removing Column with remove button - TC007
  • Columns - Removing the only one left Column with remove button - TC008
  • Columns - Changing alignment on Columns - TC009
  • Columns - Changing alignment on individual Column - TC010
  • Columns - Alignment attribute is properly passed when adding Column - TC011
  • Columns - Deep nesting is possible (iOS only)- TC012

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - TC002
  • Columns - Appearance in vertical device position (vertical layout) - TC013
  • Columns - Appearance in horizontal device position (horizontal layout) - TC014
  • Columns - Mover direction - TC015
  • Columns - Check if Column placeholder is render in nested structure - TC016
  • Columns - Unselected Column placeholder is stretched to content in nested structure- TC017

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device (TC002) - steps
  • Media Text block - Insert image from device (TC002) - steps

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Change Minimum height in pixels - TC002
  • Cover - Change Background Opacity - TC009
  • Cover - Image focal point is rendered properly - TC003
  • ⚠️ Cover - Custom color is rendered properly - TC004
  • Looks like we can't select a custom color from the web editor anymore, I used a theme color and it's working correctly. I'll update the test case.

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • The newly created Social Icons block is added with 4 icons - TC001
  • Active icon gets product color - TC002
  • Only active icons are visible when not selected - TC003

@dcalhoun
Copy link
Member

dcalhoun commented May 28, 2021

🟢 iOS Writing Flow checklist (round 1)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun
Copy link
Member

🟢 Verified the included release changes worked on an iPhone SE (49135) and Samsung Galaxy S20 (pr-14739-build-107631).

Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Whenever we are ready to merge (all CI checks pass for all PRs) we should follow the "Integrate the Release" section steps of the checklist.

@jhnstn jhnstn merged commit 40f35a6 into trunk May 28, 2021
@jhnstn jhnstn deleted the release/1.54.0 branch May 28, 2021 23:21
@jhnstn
Copy link
Member Author

jhnstn commented Jun 1, 2021

🟡 Unsupported Block Tests (Android)

  • ❓ TC001 User can edit unsupported blocks on Simple WP.com sites
    • I was able to edit the Audio block as though it were a normal supported block (the steps in the test description did not match what I saw). The Audio block was not present in the inserter, but the Audio block seemed to be fully supported on mobile, when I added it from the web.
    • I also tried using the syntaxHighlight block from web, which is not supported on mobile, and I was able to get the (?) to appear. However, after tapping, and then tapping the option to open in the browser, the block / page never loads. I'm not sure if this is a connection issue (other sites do seem to load ok at the moment, though). It makes a tiny bit of progress, based on the top bar, but after 5 minutes or so, it never makes any further progress. 🤔 This was a problem with my VPN - after resolving, it worked as expected.
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • ❓ TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
    • The post seemed to take a while to upload, so I left the post list screen and came back, and it still was pending. However, the site seemed to get the updated post, since the edits that I made were visible on web. Oddly, I then saw an additional untitled post in the post list, with the same edited (unsupported) block. This seems like an intermittent issue, and I'm not sure how to reproduce it. Mentioning it here, in case someone else has also encountered this.
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@jhnstn
Copy link
Member Author

jhnstn commented Jun 1, 2021

🟡 Unsupported Block Tests (iOS)

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
    • After getting past some connectivity issues with Jetpack to the Jurassic Ninja site (which resulted in some php error), I was able to log in and the rest of the testing worked as described.
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants