Cover Block: Allow alt text #33226
Merged
Cover Block: Allow alt text #33226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +158 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
Mamaduka
added
[Block] Cover
|
@kjellr, I think PR is ready for testing. I need to update fixtures for the integration test, but this isn't a blocker for manul tests. |
|
I've regenerated fixtures using this guide. After manual review, I think regenerated ones are correct. |
kjellr
reviewed
Jul 7, 2021
There was a problem hiding this comment.
This works great in my testing. I tried the sample text from the original issue, and also tried adding a few images and manually adding alt text using the new field. The field properly disappears when the block has no image, or when it is using video as media instead. Nice work!
I'll let someone else review the code, but functionally this seems good to go.
|
Hi, @ntsekouras I would love to get your opinion if this PR needs deprecation. We already had the |
ntsekouras
reviewed
Aug 13, 2021
Mamaduka
force-pushed
the
add/cover-block-alt-text
branch
from
380775e to
66db0d1
Compare
|
Thanks for having a look, Nik. Rebased and resolved conflicts. Waiting for checks to pass 🤞 |
|
@Mamaduka --Do you know if there is there a timeline for when this will be merged into a core release? |
|
Hey @allisonplus - since this is an enhancement, it will be included in |
|
Just wanted to drop in and say thanks to everyone for raising and fixing this! :) Waiting for 5.9 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds setting to provide alt text when image element is used for a Cover block.
I don't think we need deprecation for this feature since we already had an empty alt text attribute for image elements.
Fixes #30505.
How has this been tested?
Screenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).