[RNMobile] Fix missing block title of core/latest-posts block #34116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.03 MB ℹ️ View Unchanged
|
5 tasks
fluiddot
added a commit
that referenced
this pull request
Aug 17, 2021
fluiddot
added a commit
that referenced
this pull request
Aug 18, 2021
* Release script: Update react-native-editor version to 1.59.0 * Release script: Update with changes from 'npm run core preios' * Update release notes * Release script: Update react-native-editor version to 1.59.1 * Release script: Update with changes from 'npm run core preios' * Mobile - Global styles - Add color to the list of styles to include in the filter (#34000) * Rich text - toTree - Add optional chaining in replacements before accessing its type (#34020) * Update 1.59.1 changelog * Reinstate Unreleased section of changelog * Release script: Update react-native-editor version to 1.59.2 * Release script: Update with changes from 'npm run core preios' * Inserter: Prevent non-deterministic order of inserter items (#34078) * Prevent non-deterministic order of inserter items * Add block variations to getInserterItems unit test * Display core block variations before non-core blocks * Rename toTyped to groupByType * Update react-native-editor CHANGELOG * [RNMobile] Fix missing block title of core/latest-posts block (#34116) * Update react-native-editor CHANGELOG * [TEST] Use npm install in RN E2E Tests (iOS) workflow * Revert "[TEST] Use npm install in RN E2E Tests (iOS) workflow" This reverts commit 2b7e0e6. Co-authored-by: jhnstn <jason@readysetandco.com> Co-authored-by: David Calhoun <438664+dcalhoun@users.noreply.github.com> Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fetch the title of the block
core/latest-postsfrom the block type instead of settings, which no longer provides this value (reference).How has this been tested?
Verify that the block's title is displayed
Latest Postsblock.Latest Postsicon and title.Verify that the block's title is translated
Latest Postsblock.Latest Poststitle translated.Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).