Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.59.2 #3844

Merged
merged 9 commits into from
Aug 17, 2021
Merged

Release 1.59.2 #3844

merged 9 commits into from
Aug 17, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Aug 17, 2021 •
edited
Loading

Release for Gutenberg Mobile 1.59.2

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Inserter: Prevent non-deterministic order of inserter items

PR: WordPress/gutenberg#34078

This fix ensures that the block picker displays the blocks in the same order for both platforms iOS and Android. Previous to this change on Android, the order was not correct.

Fix missing block title of core/latest-posts block

PR: WordPress/gutenberg#34116

It fixes the issue related to the title of the Latest Posts block that wasn't being displayed.

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.
  • Test the Unsupported Block Editor on WP Apps (see steps).
  • Sanity test suites for WP Apps should be completed for each platform.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced Aug 17, 2021
Merged
Merged
Closed
Merged
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 17, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot marked this pull request as ready for review August 17, 2021 11:45
@fluiddot fluiddot requested a review from dcalhoun August 17, 2021 11:45
@dcalhoun
Copy link
Member

dcalhoun commented Aug 17, 2021 •
edited
Loading

🟢 Release Note Changes 1.59.2 (Android)

Changes

  • Inserter: Prevent non-deterministic order of inserter items

@dcalhoun
Copy link
Member

dcalhoun commented Aug 17, 2021 •
edited
Loading

🟢 Writing Flow Checklist 1.59.2 (Android)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

dcalhoun
dcalhoun approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested the release changes and Writing Flow on Android.

@fluiddot
Copy link
Contributor Author

⚠️ I've spotted that the Latest Posts block is missing the title when is added to a post/page, the issue will be addressed in this Gutenberg PR so I'm going to pause the smoke testing until it gets merged and incorporated to the beta fix.

@fluiddot
Copy link
Contributor Author

LGTM. I tested the release changes and Writing Flow on Android.

Probably we should redo part or the entire Writing Flow tests on Android after we add the fix for the Latest Posts block.

@fluiddot
Copy link
Contributor Author

fluiddot commented Aug 17, 2021 •
edited
Loading

LGTM. I tested the release changes and Writing Flow on Android.

Probably we should redo part or the entire Writing Flow tests on Android after we add the fix for the Latest Posts block.

@twstokes already covered it as per this comment in WPAndroid.

@fluiddot
Copy link
Contributor Author

fluiddot commented Aug 17, 2021 •
edited
Loading

🟢 Writing Flow Test Cases (iOS)

Tested with WPiOS build 55082 on iPhone 11 (iOS 14.2).

General

  • TC001 - Block insertion
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@fluiddot
Copy link
Contributor Author

🟢 Unsupported Block Test Cases (iOS)

Tested with WPiOS build 55082 on iPhone 11 (iOS 14.2).

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • 🟡 [skipped due to a known issue] TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@fluiddot
Copy link
Contributor Author

🟢 Test the new changes (iOS)

Tested with WPiOS build 55082 on iPhone 11 (iOS 14.2).

@fluiddot
Copy link
Contributor Author

🟢 Test the new changes (Android)

Tested with WPAndroid build 114246 on Samsung Galaxy S20 FE 5G (Android 10).

@fluiddot fluiddot added this to the 1.59.2 (18.0) milestone Aug 17, 2021
@fluiddot fluiddot enabled auto-merge August 17, 2021 17:01
@fluiddot fluiddot merged commit db5ff64 into trunk Aug 17, 2021
@fluiddot fluiddot deleted the release/1.59.2 branch August 17, 2021 17:24
@fluiddot fluiddot mentioned this pull request Aug 18, 2021
Merged
2 tasks
@fluiddot fluiddot mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
1.59.2 (18.0)
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @dcalhoun